Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requestSignIn function #2

Closed
wants to merge 7 commits into from

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Nov 17, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Closes issue #678.

Test Plan

Added unit tests

Related issues/PRs

Issue #678

@gtsonevv gtsonevv requested a review from vikinatora November 17, 2023 11:12
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just go through the PR template's checklist

@gtsonevv gtsonevv changed the title fix: set localStorage access key outside of the if statement Fix requestSignIn function Nov 27, 2023
@vikinatora vikinatora closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants