linux-yocto: enable display on QCM6490 IDP board #593

TanguduSrihitha · 2024-05-15T13:05:34Z

Add support for PM7250B PMIC, Novatek NT36672E DSI panel and enable display subsystem on QCM6490 IDP board.

Add support for the Novatek NT36672E LCD DSI panel driver. Signed-off-by: Srihitha Tangudu <[email protected]>

Enable CONFIG_DRM_PANEL_NOVATEK_NT36672E=y and CONFIG_BACKLIGHT_PWM=y instead of being selected as modules to fix bootup to shell. Signed-off-by: Srihitha Tangudu <[email protected]>

Make PM7250B SID configurable, add support for PM7250B PMIC and definition for three LEDs on QCM6490 IDP board. Signed-off-by: Srihitha Tangudu <[email protected]>

Enable display subsystem on QCM6490 IDP board. Signed-off-by: Srihitha Tangudu <[email protected]>

Disable GPU to avoid below adreno errors during display commit as there is no plan to enable GPU rendering on QCM6490 IDP board. msm_dpu ae01000.display-controller: Direct firmware load for qcom/a660_sqe.fw failed with error -2 msm_dpu ae01000.display-controller: [drm:adreno_request_fw] *ERROR* failed to load a660_sqe.fw Signed-off-by: Srihitha Tangudu <[email protected]>

lumag

Please also pick up the DP changes from the list.

lumag · 2024-05-17T10:17:58Z

.../linux-yocto/qcm6490-drivers/0002-UPSTREAM-drm-panel-Add-support-for-Novatek-NT36672E-.patch

+	struct nt36672e_panel *ctx = mipi_dsi_get_drvdata(dsi);
+
+	mipi_dsi_detach(ctx->dsi);
+	mipi_dsi_device_unregister(ctx->dsi);


There were fixups for this driver. Please pick them up too.

Sure, will pick them in the next patch.

lumag · 2024-05-17T10:20:11Z

recipes-kernel/linux/linux-yocto/bsp/qcom-armv8a/qcom-extra.cfg

-CONFIG_BACKLIGHT_PWM=m
-CONFIG_DRM_PANEL_NOVATEK_NT36672E=m
+CONFIG_BACKLIGHT_PWM=y
+CONFIG_DRM_PANEL_NOVATEK_NT36672E=y


Please describe the issue that you have and how does this fix the issue?

With the above configs set to m, when I tried initially it was working. But later on I found that on multiple reboots, it's not working most of the time. But when the above configs are set as y, the device boots to shell consistently. In the failure case, the device is getting stuck before UFS enumeration and hence the panel and backlight modules are not loaded.

DSI PHY supply(vreg_l10c_0p88) is shared among UFS and USB as well. We tried below experiments suspecting it is a shared resource issue:

As the UFS enumeration is not happening, we tried removing the PHY supply reference from the driver, the PHY probe is going ahead, but the issue is still there.

We removed disable vote on the PHY supply but the issue persists.

So, it's not related to the shared supply between DSI PHY and UFS.

Below are the last set of logs in the failure case:

[ 1.824887] platform ae01000.display-controller: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/dsi@ae94000
[ 1.837031] platform ae01000.display-controller: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/dsi@ae94000
[ 1.848618] platform ae94000.dsi: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/dsi@ae94000/panel@0
[ 1.859535] platform ae94000.dsi: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/display-controller@ae01000
[ 1.874211] msm_dsi ae94000.dsi: supply refgen not found, using dummy regulator
[ 1.882201] msm_dsi ae94000.dsi: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/dsi@ae94000/panel@0
[ 1.893073] mipi-dsi ae94000.dsi.0: Fixed dependency cycle(s) with /soc@0/display-subsystem@ae00000/dsi@ae94000
[ 1.904303] printk: console [netcon0] enabled
[ 1.908812] netconsole: network logging started
[ 1.919298] clk: Disabling unused clocks
[ 2.028658] scsi 0:0:0:49488: Well-known LUN MICRON MT256GARAT4U313Q 0104 PQ: 0 ANSI: 6
[ 2.041892] scsi 0:0:0:49476: Well-known LUN MICRON MT256GARAT4U313Q 0104 PQ: 0 ANSI: 6
[ 2.052772] scsi 0:0:0:49456: Well-known LUN MICRON MT256GARAT4U313Q 0104 PQ: 0 ANSI: 6

I tried debugging but I didn't get any breakthrough, so we decided to go with y.

This doesn't answer the question, why it is not working. So, the issue needs to be debugged and solved properly.

Please consider discussing the topic with the UFS team and with @Mani-Sadhasivam , upstream ufs-qcom maintainer. Anyway, building the panel to the kernel is not a proper fix for the UFS issue.

lumag · 2024-05-19T22:04:46Z

...linux/linux-yocto/qcm6490-board-dts/0001-DENIED-arm64-dts-qcom-qcm6490-idp-disable-gpu.patch

+no plan to enable GPU rendering in near future on QCM6490 IDP board.
+
+Signed-off-by: Srihitha Tangudu <[email protected]>
+Upstream-Status: Denied [https://lore.kernel.org/all/[email protected]/]


Simply: NAK. The GPU is present onboard, so there is no need to disable it.

Moreover, per Ritesh's email this patch is not necessary at all. GPU works on this platform.

Few of the Conrad's Adreno 643+ fixes are yet to be backported. We are in discussion with our GPU team regarding the same and adreno firmware loading enablement.

GPU on SC7280 has been supported upstream since 5.16. ZAP shader has been supported for ages. I fail to see what is so special about the QCM6490 which is supposed to be very close to SC7280.

So, yes, please backport the patches and provide the firmware for the board.

TanguduSrihitha · 2024-05-20T11:16:18Z

Please also pick up the DP changes from the list.

DP is currently not planned and hence not enabled.

lumag · 2024-05-20T11:19:38Z

@TanguduSrihitha

Please also pick up the DP changes from the list.

DP is currently not planned and hence not enabled.

DP is present on the board. The patches are available for the feature. Please pick them or provide a good reason to ignore them ('not planned' is not a good reason to leave users with the disabled feature for which the support has been implemented already).

lumag · 2024-05-21T08:15:21Z

@TanguduSrihitha Please excuse me, I got confused between IDP and RB3g2. There were no DisplayPort patches, so this is fine. Please fix the remaining issues:

GPU node disablement
missing panel driver fixes
explanation for config changes

lumag · 2024-06-20T13:26:13Z

@TanguduSrihitha any updates?

lumag · 2024-07-01T10:12:32Z

@adhudase @TanguduSrihitha another ping.

TanguduSrihitha · 2024-07-05T09:02:59Z

Hi @lumag, sorry for the delay in response.

1) Compiling panel and PWM as modules: We have worked with the internal stability team and got forced crash dumps when the device is stuck. Many debug configs are not enabled by default and it took multiple iterations for us to get a parsable dump. From the tasks list and stack traces of the parsed dump, we found that the device is going into a deadlock due to clk prepare_lock MUTEX. We are working with the internal clock team to identify the root cause.

2) Missing panel driver fixes: I'll update in the next patch once we conclude on the panel and PWM configs setting.

3) Backporting of Conrad's fixes and Adreno firmware loading enablement: The GPU team is currently busy with Lemans and they'll consider support on 0.0/meta-qcom post that, probably after 7/15.

lumag · 2024-08-19T12:41:19Z

@TanguduSrihitha any updates? We are past 15th of August.

TanguduSrihitha added 5 commits May 15, 2024 11:02

linux-yocto: Add Novatek NT36672E LCD DSI panel

2f1a193

Add support for the Novatek NT36672E LCD DSI panel driver. Signed-off-by: Srihitha Tangudu <[email protected]>

linux-yocto: compile NT36672E panel and backlight PWM as built-in

58fe022

Enable CONFIG_DRM_PANEL_NOVATEK_NT36672E=y and CONFIG_BACKLIGHT_PWM=y instead of being selected as modules to fix bootup to shell. Signed-off-by: Srihitha Tangudu <[email protected]>

linux-yocto: Add support for PM7250B PMIC on QCM6490 IDP board

9b854a7

Make PM7250B SID configurable, add support for PM7250B PMIC and definition for three LEDs on QCM6490 IDP board. Signed-off-by: Srihitha Tangudu <[email protected]>

linux-yocto: add display and panel on QCM6490 IDP board

92c69f7

Enable display subsystem on QCM6490 IDP board. Signed-off-by: Srihitha Tangudu <[email protected]>

lumag requested changes May 17, 2024

View reviewed changes

lumag reviewed May 19, 2024

View reviewed changes

lumag mentioned this pull request Jul 25, 2024

info: flash core-image-minimal into rb3gen2 qcs6490 #616

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linux-yocto: enable display on QCM6490 IDP board #593

linux-yocto: enable display on QCM6490 IDP board #593

TanguduSrihitha commented May 15, 2024

lumag left a comment

lumag May 17, 2024

TanguduSrihitha May 20, 2024

lumag May 17, 2024

TanguduSrihitha May 22, 2024

lumag May 22, 2024

lumag May 22, 2024

lumag May 19, 2024

lumag May 19, 2024

TanguduSrihitha May 22, 2024

lumag May 22, 2024

lumag May 22, 2024

TanguduSrihitha commented May 20, 2024

lumag commented May 20, 2024

lumag commented May 21, 2024

lumag commented Jun 20, 2024

lumag commented Jul 1, 2024

TanguduSrihitha commented Jul 5, 2024

lumag commented Aug 19, 2024

linux-yocto: enable display on QCM6490 IDP board #593

Are you sure you want to change the base?

linux-yocto: enable display on QCM6490 IDP board #593

Conversation

TanguduSrihitha commented May 15, 2024

lumag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TanguduSrihitha commented May 20, 2024

lumag commented May 20, 2024

lumag commented May 21, 2024

lumag commented Jun 20, 2024

lumag commented Jul 1, 2024

TanguduSrihitha commented Jul 5, 2024

lumag commented Aug 19, 2024