firmware-qcom-rb3gen2: fix dependency on pil-squasher #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be a dependency on the -native flavor, since the tool is used during the build. Interestingly it worked fine so far! That's because pil-squasher-native is already added to DEPENDS in firmware-qcom-adreno.inc. I have decided to leave it here as well, since pil-squasher is used in this recipe too. With pil-squasher in DEPENDS, it breaks the yocto-checklayer script with: allarch firmware-qcom-rb3gen2:do_prepare_recipe_sysroot: a4777557300156768d6ed9c776ef216d82576f103a9382c35ac6595e3008c967 (qcm6490-idp, sa8775p-ride-sx, qcs6490-rb3gen2-core-kit) != a121b24b301e93b1153c72e858cf4ced5217306d9a7c9ed51bf14c56434c1ce3 (qcom-armv7a) != 16bcafbe404dd2e0b58c4a86ca923c8760273fac69a8237008f78f3d4f9b2efe (qcom-armv7a-modem) != a5cfc0b555ce8fc4b76bfdd5a1f9c600cb9db2ac052005d43109ebe239fbd902 (qcom-armv8a) 11 tasks where not listed because some other task of the recipe already differed. It is likely that differences from different recipes also have the same root cause. To investigate, run bitbake-diffsigs -t recipename taskname -s fromsig tosig. Example: (qcom-armv7a-modem) != (qcm6490-idp, sa8775p-ride-sx, qcs6490-rb3gen2-core-kit) in the last line Command: bitbake-diffsigs -t firmware-qcom-rb3gen2 do_prepare_recipe_sysroot -s 16bcafbe404dd2e0b58c4a86ca923c8760273fac69a8237008f78f3d4f9b2efe a4777557300156768d6ed9c776ef216d82576f103a9382c35ac6595e3008c967 NOTE: Reconnecting to bitbake server... Hash for task dependency pil-squasher:do_populate_sysroot changed from 99a1116a1f50873ce3b8b1ab8c710b8e47fae6419feb9a7a18c2faadbf8ac7c6 to c0f327088cdd9c8eccfa4ed3835220c0fd997700de096a4bffdd060c1095990b Signed-off-by: Nicolas Dechesne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be a dependency on the -native flavor, since the tool is used during the build. Interestingly it worked fine so far! That's because pil-squasher-native is already added to DEPENDS in firmware-qcom-adreno.inc.
I have decided to leave it here as well, since pil-squasher is used in this recipe too.
With pil-squasher in DEPENDS, it breaks the yocto-checklayer script with:
allarch firmware-qcom-rb3gen2:do_prepare_recipe_sysroot: a4777557300156768d6ed9c776ef216d82576f103a9382c35ac6595e3008c967 (qcm6490-idp, sa8775p-ride-sx, qcs6490-rb3gen2-core-kit) != a121b24b301e93b1153c72e858cf4ced5217306d9a7c9ed51bf14c56434c1ce3 (qcom-armv7a) != 16bcafbe404dd2e0b58c4a86ca923c8760273fac69a8237008f78f3d4f9b2efe (qcom-armv7a-modem) != a5cfc0b555ce8fc4b76bfdd5a1f9c600cb9db2ac052005d43109ebe239fbd902 (qcom-armv8a)
11 tasks where not listed because some other task of the recipe already differed. It is likely that differences from different recipes also have the same root cause.
To investigate, run bitbake-diffsigs -t recipename taskname -s fromsig tosig. Example: (qcom-armv7a-modem) != (qcm6490-idp, sa8775p-ride-sx, qcs6490-rb3gen2-core-kit) in the last line Command: bitbake-diffsigs -t firmware-qcom-rb3gen2 do_prepare_recipe_sysroot -s 16bcafbe404dd2e0b58c4a86ca923c8760273fac69a8237008f78f3d4f9b2efe a4777557300156768d6ed9c776ef216d82576f103a9382c35ac6595e3008c967
NOTE: Reconnecting to bitbake server...
Hash for task dependency pil-squasher:do_populate_sysroot changed from 99a1116a1f50873ce3b8b1ab8c710b8e47fae6419feb9a7a18c2faadbf8ac7c6 to c0f327088cdd9c8eccfa4ed3835220c0fd997700de096a4bffdd060c1095990b