Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Fixed Potential truncation issue in LabelLayout #260

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Fixed Potential truncation issue in LabelLayout #260

merged 1 commit into from
Jun 17, 2019

Conversation

p-jadhav
Copy link
Contributor

@p-jadhav p-jadhav commented Jun 7, 2019

  • Added line break mode support in LabelLayout to calculate correct size based on line break mode.
  • Added LabelLayout unit test to verify that size calculation logic considers line break mode while calculating LabelLayout size.
  • These changes are duplicate of pull request Fixed Potential truncation issue in LabelLayout #229

@p-jadhav
Copy link
Contributor Author

p-jadhav commented Jun 7, 2019

Truncation_Issue
Truncation_Issue_Fixed

@p-jadhav p-jadhav mentioned this pull request Jun 7, 2019
Open
@pa1-linkedin pa1-linkedin self-requested a review June 11, 2019 22:42
@p-jadhav
Fixed Potential truncation issue in LabelLayout
3652784 
- Added line break mode support in LabelLayout to calculate correct size based on line break mode.
- Added LabelLayout unit test to verify that size calculation logic considers line break mode while calculating LabelLayout size.
@p-jadhav p-jadhav closed this Jun 12, 2019
@p-jadhav p-jadhav force-pushed the LabelLayout_HeightCalculation_Fix branch from ec0a345 to c874993 Compare June 12, 2019 09:21
@p-jadhav p-jadhav reopened this Jun 12, 2019
@pa1-linkedin pa1-linkedin merged commit 34abc8e into LinkedInAttic:master Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pa1-linkedin pa1-linkedin pa1-linkedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-jadhav @pa1-linkedin