This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Calculate arrow offset without border #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimmi88 I don't know why the tests failed. I tried to merge the changes from the master into this pull request. Not sure if something went wrong there. My changes are very small. Maybe you could take a look at it and merge this pull request. |
|
Doesn't look like this failure is due to the change. Nonetheless, I'd like to figure out why the build is failing. Time permitting, I'll dig into this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue: #325
Minimal example: http://fiddle.jshell.net/x62303x6/
Changes the arrow offset calculation to be calculated without border since the arrow is moved relative to the content bubble.
el.offsetWidth & el.offsetHeight => width + padding + border
el.clientWidth & el.clientHeight => height + padding
Therefor use clientWidth & clientHeight for the arrow offset instead of offsetWidth & offsetHeight.