Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handle for get_stream_contents #23

Merged
merged 5 commits into from
Dec 11, 2022
Merged

Add error handle for get_stream_contents #23

merged 5 commits into from
Dec 11, 2022

Conversation

cczhong11
Copy link
Contributor

Some articles did not have content so it would throw Error in
Article.from_json
Add try catch to avoid throw exception

@cczhong11
Copy link
Contributor Author

also add limitation on the get_stream_contents

@Linusp Linusp self-requested a review December 6, 2022 15:00
@Linusp Linusp added the enhancement New feature or request label Dec 6, 2022
@Linusp Linusp merged commit 1ff58ac into Linusp:master Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linusp Linusp Awaiting requested review from Linusp

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cczhong11 @Linusp