Added 'n' param to fetch_articles method #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding n param to fetch_articles method in order to include in request to stream/contents/[streamId] endpoint. This will be helpful to users who want to increase the number of items returned in order to preserve total API requests and not reach limit too early
|
Hmm……I hadn't noticed this parameter before your suggestion. Thank you so much for your Pull Request! It looks good to me so I'll merge it and release a new version later. Your contribution will be noted in the release notes. 😄 |
|
@Linusp thank you! When do you expect to release the new version? This will be a huge help for my team so I appreciate it whenever you get the chance no rush |
|
@tosborne-slalom I've made some additional changes, please review them here: #30 |
|
@tosborne-slalom Thanks for your contribution again. I want to let you know that I have released the new version. Now you can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding n param to fetch_articles method in order to include in request to stream/contents/[streamId] endpoint. This will be helpful to users who want to increase the number of items returned in order to preserve total API requests and not reach limit too early. Default is 20 returned items if 'n' parameter is not specified in request so would like the ability to set this based on user preference.