Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs info: Should Accessible2_3.idl be included in build tools #18

Open
OzancanKaratas opened this issue Mar 5, 2022 · 4 comments
Open

Comments

@OzancanKaratas
Copy link

OzancanKaratas commented Mar 5, 2022

@jcsteh, should Accessible2_3.idl be included in build tools? It doesn't exist in concatidl.sh.

@michaelDCurran, I'm trying to add the IAccessibleTextSelectionContainer interface into NVDA. There is a compile error. I want to synchronize NVDA scripts with that of this repository. However, I'm not sure if there is a change that needs to be made here.

@michaelDCurran
Copy link
Contributor

This was an error introduced by me in pr #17

build\x86\ia2.idl(3292) : error MIDL2025 : syntax error : expecting a type specification near "bool"

'bool' does not exist in IDL, rather the data type should be 'boolean'.
I have addressed this in pr #19

@jcsteh
Copy link
Collaborator

jcsteh commented Mar 6, 2022

IAccessible2_3 should be considered deprecated, as its only method has problems that were corrected in the new IAccessibleTextSelectionContainer interface. This is why it's not included in the concatenated idl any more.

@OzancanKaratas
Copy link
Author

@jcsteh, thanks for your comment.

@michaelDCurran, please delete Accessible2_3.idl in your pull request. I'll edit NVDA's code.

@jcsteh jcsteh closed this as completed in 77b27f7 Mar 31, 2022
@asurkov
Copy link
Member

asurkov commented Mar 31, 2022

If IAccessible2_3 not included into concatenated IDL, then does it mean it's safe for implementations to not implement it for backward compatibility? Otherwise, it adds a pain to keep IDL updated on the implementator's side. Also, note, deprecated AccessibleTable interface is included into the combined IDL. Is IAccessible2_3 different from it? I could buy it if you say no one effectively using it and thus it can be safely deleted.

Reopening since the missing IAccessible2_3 interface issue was in the original description.

@asurkov asurkov reopened this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants