Fix compilation errors of IAccessibleTextSelectionContainer #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include IAccessibleTextSelectionContainer in the type library. Signed-off-by: Michael Curran <[email protected]>
This was referenced Mar 6, 2022
jcsteh
requested changes
Mar 8, 2022
api/IA2TypeLibrary.idl
Outdated
| @@ -87,6 +87,7 @@ library IAccessible2Lib | |||
| interface IAccessibleTableCell; | |||
| interface IAccessibleText; | |||
| interface IAccessibleText2; | |||
| IAccessibleTextSelectionContainer; | |||
There was a problem hiding this comment.
I assume this is not meant to be in the diff?
There was a problem hiding this comment.
Not a mistake. IAccessibleTextSelectionContainer should be included in the type library. I forgot to do that in #17
There was a problem hiding this comment.
But it just says "IAccessibleTextSelectionContainer"; there's no "interface" statement?
There was a problem hiding this comment.
Oh... right. It still compiled the type library fine. So I guess the keyword is not technically needed. However, I've added it in now. Yep, that was a mistake.
michaelDCurran
commented
Mar 8, 2022
Add missing interface keyword
|
#20 included some other minor documentation and spacing fixes, so I merged that instead, but it is effectively the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18
Issue
Fix
Testing
Upgraded NVDA to include IAccessible2 with IAccessibleTextSelectionContainer. Ensured that IAccessibleTextSelectionContainer appeared in NVDA's COM interfaces.
Signed-off-by: Michael Curran [email protected]