Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmoccapy - added more LOG.debug #3123

Open
wants to merge 1 commit into
base: 2.9
Choose a base branch
from
Open

Gmoccapy - added more LOG.debug #3123

wants to merge 1 commit into from

Conversation

zz912
Copy link
Contributor

@zz912 zz912 commented Sep 17, 2024

I am makeing it still again, again, again.
So I made PR.

I makeing it still again, again, again.
So I made PR.
@hansu
Copy link
Member

hansu commented Sep 17, 2024

I think this should better go into master

@zz912
Copy link
Contributor Author

zz912 commented Sep 18, 2024

I would like to ask you to consider merge it to branche 2.9.

Reasons:

  • Gmoccapy in branch 2.9 still shows strange random behavior in the tool change area even with automatic G43 deleted. These notes might help other users in finding the source of the bug.
    I have done a retrofit from version 2.9 and I don't want to go to version 2.10 if there is only need to find bugs (maybe my bugs, maybe LCNC bugs) related to ATC.
  • branche 2.9 is still a STABLE version and is used for comparison when looking for bugs in other versions. Therefore, I want the same messages in 2.9 and in 2.10
    For example here:
    2.10 Gmoccapy - remap M61 disable show MDI window #3120
  • I don't think this PR is so dangerous that it can't be merged until 2.9

@gmoccapy
Copy link
Collaborator

I agree with hansu,
This changes are to be merged to master.

  • Changing of a behavior of a GUI and therefor the machine in a stable release is not good to do.

Norbert

@zz912
Copy link
Contributor Author

zz912 commented Sep 19, 2024

I added only LOG.debug for better description of bugs in 2.9. How did I changed behavior?

@andypugh
Copy link
Collaborator

I am undecided on where this should go. I don't think that it actually changes the GUI behaviour, but at the same time it isn't quite a bugfix.

Does it have any effect on the "runtests" stage? Tests tend to compare terminal output. But given that the checks have passed (which include running the tests) I assume that it hasn't changed anything there.

So, I have no real opinion, but don't object to it going into 2.9.

@gmoccapy
Copy link
Collaborator

After the "misbehavior" has been fixed all the debug output is not needed any more.
I vote to not include the addinonal outputs at all.

But it is just my opinion and I have not checked the latest changes done in gmoccapy

@zz912
Copy link
Contributor Author

zz912 commented Sep 22, 2024

Software without bugs is just poorly tested software. :-D

@zz912 zz912 changed the base branch from 2.9 to master September 22, 2024 12:53
@zz912 zz912 marked this pull request as draft September 22, 2024 12:54
@zz912 zz912 changed the base branch from master to 2.9 September 22, 2024 12:55
@zz912 zz912 closed this Sep 22, 2024
@zz912 zz912 deleted the patch-32 branch September 22, 2024 12:58
@zz912 zz912 restored the patch-32 branch September 22, 2024 13:08
@zz912 zz912 reopened this Sep 22, 2024
@zz912 zz912 marked this pull request as ready for review September 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants