Fix hal warnings #3199
Closed
Fix hal warnings #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e conditions are still not considered.
into a pointer by SHMPTR(), which forcefully drops the volatile attribute. In modern C/C++ a warning is emitted when you declare volatile scalar arguments or volatile return values. Using volatile in these cases have always been problematic for what they actually mean and should do. Note that not all volatile modifiers are removed because many are in the context of pointer references, where they are important.
|
I will split this PR into smaller pieces. There are several other things I've seen that make no sense. These will be separated into smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings about using the volatile modifier. Not all instances of volatile are removed. Volatile is only removed from scalar arguments and return values. All other instances remain as they were because volatile has a defined meaning in those contexts (even though not all may be required). All tests (scripts/runtests) pass (except see #3198).
The PR also addresses the warnings in hal/classicladder about wrong snprintf() size argument and failing to check return values of fgets() and write().