Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent silencing of make messages #3235

Merged

Conversation

BsAtHome
Copy link
Contributor

Making man pages is way more verbose than all other jobs. This PR streamlines the a2x call for making man pages to use the same noise limiting procedure. It removes a lot of clutter in the terminal when doing a build.

Additionally, reducing the clutter exposed some formatting warnings which are also fixed. There may be warnings left about "too many manpage names", but this is an internal asciidoc issue.

@BsAtHome
Copy link
Contributor Author

Actually, the reason is that $(notdir $@)is already used many places (or $*, $<, ... instead of $@). Using $(dir $@) is IMO more clear and consistent.

@andypugh andypugh merged commit 51a6b66 into LinuxCNC:master Jan 5, 2025
10 checks passed
@snowgoer540
Copy link
Contributor

So much better ... thanks for this!

@BsAtHome BsAtHome deleted the fix_a2x-verbosity-and-formatting branch January 8, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants