fix(whmcs-status): handle null correctly in whmcs api response

Linuxfabrik · Jan 31, 2025 · d1afdf6 · d1afdf6
1 parent 713f4df
commit d1afdf6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02 b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE02
@@ -170,6 +170,8 @@
         "severityLevel": "info",
         "body": "<p>Your PHP version <strong>8.1.31</strong> is supported by WHMCS. </p><p>Your PHP version does not receive regular updates but is the latest supported by WHMCS.</p>"
       }
-    ]
+    ],
+    "warning": null,
+    "danger": null
   }
 }
diff --git a/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03 b/check-plugins/whmcs-status/unit-test/stdout/EXAMPLE03
@@ -164,6 +164,8 @@
         "severityLevel": "notice",
         "body": "WHMCS is not running behind a CloudFlare proxy."
       }
-    ]
+    ],
+    "warning": null,
+    "danger": null
   }
 }
diff --git a/check-plugins/whmcs-status/whmcs-status b/check-plugins/whmcs-status/whmcs-status
@@ -149,6 +149,8 @@ def get_failed_checks(checks):
     """
     failed_checks = []
     for _, items in checks.get('checks', {}).items():
+        if items is None:
+            continue
         for item in items:
             if item.get('severityLevel') == 'notice':
                 continue