fix(ESSNTL-5136): Check for null id when the host is ungroupped (RedH…

…atInsights#1975)

Implements https://issues.redhat.com/browse/ESSNTL-5136.

package.json

@@ -15,7 +15,7 @@
     "@patternfly/react-icons": "^4.93.7",
     "@redhat-cloud-services/frontend-components": "^3.11.3",
     "@redhat-cloud-services/frontend-components-notifications": "^3.2.14",
-    "@redhat-cloud-services/frontend-components-utilities": "^3.7.5",
+    "@redhat-cloud-services/frontend-components-utilities": "^3.7.6",
     "@redhat-cloud-services/host-inventory-client": "1.2.3",
     "@unleash/proxy-client-react": "^3.5.0",
     "awesome-debounce-promise": "^2.1.0",

src/components/GeneralInfo/EditButton/EditButton.js

@@ -34,10 +34,9 @@ const EditButtonUnknownPermissions = (props) => {
   const entity = useSelector(({ entityDetails }) => entityDetails?.entity);
 
   const { hasAccess: canEditHost } = usePermissionsWithContext([
-    'inventory:hosts:write',
-    ...(entity?.groups?.[0]?.id !== undefined // if the host is in a group, then we can check group level access
-      ? [REQUIRED_PERMISSION_TO_MODIFY_HOST_IN_GROUP(entity?.groups?.[0]?.id)]
-      : []),
+    REQUIRED_PERMISSION_TO_MODIFY_HOST_IN_GROUP(
+      entity?.groups?.[0]?.id ?? null // null stands for ungroupped hosts
+    ),
   ]);
 
   if (!canEditHost) {

src/routes/InventoryDetail.cy.js

@@ -118,4 +118,39 @@ describe('rbac integration', () => {
       cy.get(MODAL).find('h1').contains('Edit Ansible host');
     });
   });
+
+  describe('with excluding group permissions', () => {
+    before(() =>
+      cy.mockWindowChrome({
+        userPermissions: [
+          {
+            permission: 'inventory:hosts:write',
+            resourceDefinitions: [
+              {
+                attributeFilter: {
+                  key: 'group.id',
+                  operation: 'equal',
+                  value: null,
+                },
+              },
+            ],
+          },
+        ],
+      })
+    );
+
+    beforeEach(prepareTest);
+
+    it('should enable delete and edit buttons', () => {
+      cy.contains('Delete').should('exist').and('be.enabled');
+    });
+
+    it('should enable edit buttons', () => {
+      cy.ouiaId('Display name value').find('[aria-label="Edit"]').click();
+      cy.get(MODAL).find('h1').contains('Edit display name');
+      cy.ouiaId('edit-display-name-modal-ModalBoxCloseButton').click();
+      cy.ouiaId('Ansible hostname value').find('[aria-label="Edit"]').click();
+      cy.get(MODAL).find('h1').contains('Edit Ansible host');
+    });
+  });
 });

src/routes/InventoryDetail.js

@@ -113,10 +113,9 @@ const Inventory = () => {
   const clearNotifications = () => dispatch(actions.clearNotifications());
 
   const { hasAccess: canDeleteHost } = usePermissionsWithContext([
-    'inventory:hosts:write',
-    ...(entity?.groups?.[0]?.id !== undefined // if the host is in a group, then we can check group level access
-      ? [REQUIRED_PERMISSION_TO_MODIFY_HOST_IN_GROUP(entity?.groups?.[0]?.id)]
-      : []),
+    REQUIRED_PERMISSION_TO_MODIFY_HOST_IN_GROUP(
+      entity?.groups?.[0]?.id ?? null // null stands for ungroupped hosts
+    ),
   ]);
 
   useEffect(() => {