Move relayer inventory config to external json file #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where would we like to store json file for relayer inventory config? |
Maybe, let's add it to |
sameersubudhi
approved these changes
Aug 19, 2024
Incede
approved these changes
Aug 19, 2024
sameersubudhi
deleted the
LISK-885-move-across-inventory-config-to-external-file
branch
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 6, 2024
### What was the problem? This PR resolves LISK-885. ### How was it solved? - [x] Instead of using `RELAYER_INVENTORY_CONFIG` variable which has `json` string, `RELAYER_EXTERNAL_INVENTORY_CONFIG` is used containing file path to `json` file with a relayer inventory config. ### How was it tested? Run `yarn relay --wallet void --address <ADDRESS>`, after setting `RELAYER_EXTERNAL_INVENTORY_CONFIG` variable in `.env` file.
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-885. ### How was it solved? - [x] Instead of using `RELAYER_INVENTORY_CONFIG` variable which has `json` string, `RELAYER_EXTERNAL_INVENTORY_CONFIG` is used containing file path to `json` file with a relayer inventory config. ### How was it tested? Run `yarn relay --wallet void --address <ADDRESS>`, after setting `RELAYER_EXTERNAL_INVENTORY_CONFIG` variable in `.env` file.
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-885. ### How was it solved? - [x] Instead of using `RELAYER_INVENTORY_CONFIG` variable which has `json` string, `RELAYER_EXTERNAL_INVENTORY_CONFIG` is used containing file path to `json` file with a relayer inventory config. ### How was it tested? Run `yarn relay --wallet void --address <ADDRESS>`, after setting `RELAYER_EXTERNAL_INVENTORY_CONFIG` variable in `.env` file.
sameersubudhi
pushed a commit
that referenced
this pull request
Sep 10, 2024
### What was the problem? This PR resolves LISK-885. ### How was it solved? - [x] Instead of using `RELAYER_INVENTORY_CONFIG` variable which has `json` string, `RELAYER_EXTERNAL_INVENTORY_CONFIG` is used containing file path to `json` file with a relayer inventory config. ### How was it tested? Run `yarn relay --wallet void --address <ADDRESS>`, after setting `RELAYER_EXTERNAL_INVENTORY_CONFIG` variable in `.env` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves LISK-885.
How was it solved?
RELAYER_INVENTORY_CONFIGvariable which hasjsonstring,RELAYER_EXTERNAL_INVENTORY_CONFIGis used containing file path tojsonfile with a relayer inventory config.How was it tested?
Run
yarn relay --wallet void --address <ADDRESS>, after settingRELAYER_EXTERNAL_INVENTORY_CONFIGvariable in.envfile.