Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement upgraded version for price feed smart contract #218

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Implement upgraded version for price feed smart contract #218

merged 5 commits into from
Dec 10, 2024

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Dec 10, 2024

What was the problem?

This PR resolves #LISK-1424.

How was it solved?

  • new L2PriceFeedWithoutRoundsV2 smart contract was implemented
  • deployment scripts for L2PriceFeedWithoutRoundsV2 were implemented
  • added fix for RedStone main demo constant value
  • added two new RedStone data service URLs

How was it tested?

  • new and old unit tests pass

@matjazv matjazv self-assigned this Dec 10, 2024
ricott1
ricott1 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ricott1 ricott1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed on a local fork and ran the tests. Everything is good from my side. I didn't check the web3-functions changes carefully as I am not sure how to test them, but they seem okay to me.

sameersubudhi
sameersubudhi requested changes Dec 10, 2024
View reviewed changes
script/upgraded/deployPriceFeedWithoutRoundsV2.sh Outdated Show resolved Hide resolved
test/L2/L2PriceFeedWithoutRounds.t.sol Outdated Show resolved Hide resolved
web3-functions/redstone/index.ts Show resolved Hide resolved
@sameersubudhi sameersubudhi merged commit 12311ae into development Dec 10, 2024
4 checks passed
@sameersubudhi sameersubudhi deleted the LISK-1424-Upgrade-LSK-USD-price-feed-smart-contract branch December 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameersubudhi sameersubudhi sameersubudhi approved these changes

@ricott1 ricott1 ricott1 approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matjazv @ricott1 @sameersubudhi