Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple and upgrade dependencies to the latest versions #220

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Decouple and upgrade dependencies to the latest versions #220

merged 8 commits into from
Dec 23, 2024

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Dec 13, 2024

What was the problem?

This PR resolves #LISK-1393.

How was it solved?

  • Dependencies for Web3 Actions were updated
  • Dependencies for Web3 Functions were updated. Unnecessary ones were removed.
  • Versions of dependencies were considered based on Dependabot suggestions.
  • Code inside Web3 Functions were reorganized into multiple files.
  • Logging output inside Web3 Functions were reduced to be able to see full logs inside Gelato's dashboard

How was it tested?

  • Web3 Actions werre locally built.
  • Web3 Functions were deployed on Sepolia network and tested inside Gelato's dashboard

@matjazv matjazv self-assigned this Dec 13, 2024
@sameersubudhi sameersubudhi force-pushed the LISK-1393-Upgrade-dependencies-in-lisk-contracts-to-address-security-vulnerabilities branch from cb49eb8 to 2f75abe Compare December 16, 2024 09:54
@sameersubudhi sameersubudhi force-pushed the LISK-1393-Upgrade-dependencies-in-lisk-contracts-to-address-security-vulnerabilities branch from a8ff7a1 to 8d209ce Compare December 16, 2024 11:49
sameersubudhi
sameersubudhi approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes in web3-actions and verified in web3-functions. LGTM now! 👍

@sameersubudhi sameersubudhi merged commit 613a0ff into development Dec 23, 2024
4 checks passed
@sameersubudhi sameersubudhi deleted the LISK-1393-Upgrade-dependencies-in-lisk-contracts-to-address-security-vulnerabilities branch December 23, 2024 10:32
@matjazv matjazv mentioned this pull request Dec 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Incede Incede Incede approved these changes

@sameersubudhi sameersubudhi sameersubudhi approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matjazv @sameersubudhi @Incede