Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Slither warnings for L2LiskToken smart contract #49

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Resolve Slither warnings for L2LiskToken smart contract #49

merged 2 commits into from
Feb 22, 2024

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Feb 22, 2024

What was the problem?

This PR resolves #47.

How was it solved?

  • Slither warnings were fixed and unit tests for them were created.
  • Warnings regarding Solidity compiler version and naming convention were not resolved.

How was it tested?

  • New unit tests were implemented.
  • Slither tool was ran against new code and warnings were checked.

@matjazv matjazv self-assigned this Feb 22, 2024
AndreasKendziorra
AndreasKendziorra approved these changes Feb 22, 2024
View reviewed changes
src/L2/L2LiskToken.sol Show resolved Hide resolved
@AndreasKendziorra AndreasKendziorra self-requested a review February 22, 2024 08:41
AndreasKendziorra
AndreasKendziorra requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@AndreasKendziorra AndreasKendziorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the compiler version be set to 0.8.23 everywhere in this commit, or is this supposed to be done at a later stage?

src/L2/L2LiskToken.sol Show resolved Hide resolved
@matjazv matjazv merged commit e7eab33 into main Feb 22, 2024
3 checks passed
@matjazv matjazv deleted the 47-slither-warnings branch February 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasKendziorra AndreasKendziorra AndreasKendziorra approved these changes

@Phanco Phanco Phanco approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve warnings for L2LiskToken contract found by Slither
3 participants
@matjazv @Phanco @AndreasKendziorra