Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compile typeError #3123

Closed

Conversation

Duncan-Brain
Copy link
Collaborator

@Duncan-Brain Duncan-Brain commented Feb 9, 2024

Description
Screenshot 2024-02-09 at 2 48 46 PM

Some recently updated package is triggering an inconsistently replicable bug shown above. This PR is available should it happen more often and we need to correct it.

There seems to be some issue with how vite compiles and how some MUI modules use esm vs cjs. From what I can tell vite is not compiling right but some MUI modules are being updated to new conventions.

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@Duncan-Brain Duncan-Brain requested review from a team as code owners February 9, 2024 19:59
@Duncan-Brain Duncan-Brain requested review from antsgar and kathyavini and removed request for a team February 9, 2024 19:59
@Duncan-Brain Duncan-Brain self-assigned this Feb 9, 2024
@Duncan-Brain
Copy link
Collaborator Author

Note to self: Add and removal of this as temporary fix has unintended issues. For example classes stopped working on TableHead.jsx . I think a compiled chunk was not enough of an error to break but was out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant