New dark mode look and Minecraftia font boxes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page will be in dark mode if the computer is in dark mode. The font of texts under "Connection" box, "Whitelist" box, and "Blacklist" box will all now be Minecraftia.
zyxkad
requested changes
Mar 13, 2024
| @@ -244,7 +247,7 @@ onMounted(async () => { | |||
| </div> | |||
| </fieldset> | |||
| <div v-else> | |||
| <i><b>Loading...</b></i> | |||
| <!--<i><b>Loading...</b></i>-->Loading... | |||
There was a problem hiding this comment.
字体不对不是删掉的理由 😅
给它加个 class, 然后 css 里面设置 font-family 就好
| @@ -111,6 +111,7 @@ async function refresh(): Promise<void> { | |||
|
|
|||
| var loginPromise: Promise<void> | null = null | |||
|
|
|||
| /*whoever don't have an account butwant to check how it looks delete this function*/ | |||
There was a problem hiding this comment.
我不建议在这里加这个 comment, 之后我加个 dev api 吧
| @@ -224,7 +225,9 @@ onMounted(async () => { | |||
| <legend class="config-box-title"> | |||
| <h3>Connections</h3> | |||
| </legend> | |||
| <div v-if="connPollError" class="error">{{ connPollError }}</div> | |||
| <!-- replacement code to check whether error visual works | |||
| <div v-if= "false||connPollError" class="error">{{ connPollError }}</div> --> | |||
| } | ||
| } | ||
|
|
||
| /*main resources*/ |
There was a problem hiding this comment.
Suggested change
| /*main resources*/ | |
| /* main resources */ |
| box-shadow: 0 0 2px #000a; | ||
| } | ||
|
|
||
| @media(max-width: 45rem) { |
There was a problem hiding this comment.
@media放最下面，因为按照 css 加载顺序来说，下面的值会覆盖上面的值
就是让代码更好看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page will be in dark mode if the computer is in dark mode. The font of texts under "Connection" box, "Whitelist" box, and "Blacklist" box will all now be Minecraftia.