Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-1664 - Adjust the analytics adapter #49

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

CM-1664 - Adjust the analytics adapter #49

wants to merge 41 commits into from

Conversation

3link
Copy link

@3link 3link commented Feb 14, 2025 •
edited
Loading

https://liveintent.atlassian.net/browse/CM-1664

  • Use GET instead of POST
  • Listen to bid won event instead of waiting for 2s for winning bid to appear
  • Optionally, collect info about all initiated auctions

Related PRs:

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+1 error)

wi101
wi101 reviewed Feb 18, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 13 linter errors (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+13 errors)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 12 linter errors (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+12 errors)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 12 linter errors (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+12 errors)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 13 linter errors (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)
  • modules/liveIntentAnalyticsAdapter.js (+12 errors)

@github-actions GitHub Actions
Copy link

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • libraries/liveIntentId/idSystem.js (+1 error)

peixunzhang
peixunzhang reviewed Feb 19, 2025
View reviewed changes
modules/liveIntentAnalyticsAdapter.js Outdated
}

function ignoreUndefined(data) {
const filteredData = Object.entries(data).filter(([key, value]) => value)
return Object.fromEntries(filteredData)
const filteredData = Object.entries(data).filter(([key, value]) => value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can Object.entries(data) be undefined with the new setting?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, there is not way for it to be undefined.

@wi101 wi101 mentioned this pull request Feb 19, 2025
Merged
@3link
Copy link
Author

3link commented Feb 28, 2025

@peixunzhang Thank you for adjusting the parameter names in the tests 👍

@3link 3link marked this pull request as ready for review February 28, 2025 08:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+2 errors)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/liveIntentAnalyticsAdapter.js (+2 errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wi101 wi101 wi101 left review comments

@peixunzhang peixunzhang peixunzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3link @wi101 @peixunzhang