Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pogo3D autosplitter with settings for full game #1612

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

mitchell-merry
Copy link
Contributor

If you are adding or modifying an Auto Splitter, please fill out this checklist:

  • My Auto Splitter does not contain any malicious functionality and I'm entirely responsible for any damages myself. (Any kind of abuse in an Auto Splitter will result in an immediate ban.)
  • I am not replacing an existing Auto Splitter by a different author, or I have received permission from the author to replace the existing Auto Splitter.
  • The Auto Splitter has an open source license that allows anyone to fork and host it.

@@ -610,6 +610,7 @@
</Games>
<URLs>
<URL>https://raw.githubusercontent.com/mitchell-merry/autosplitters/main/Pogo3D/pogo3d.asl</URL>
<URL>https://raw.githubusercontent.com/mitchell-merry/autosplitters/main/Pogo3D/Pogo3D.Settings.xml</URL>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this re-download the file every time you open LiveSplit, and overwrite the existing settings? Why not use LiveSplit's built in auto splitter settings?

Copy link
Contributor

@just-ero just-ero Dec 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a file that is loaded to provide the built-in auto splitter settings. For such a tiny amount of settings though, I hardly see the reason in offloading them to some other file. I created that feature for asl-help for auto splitters that have hundreds of settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have to modify this file later to change the settings? For an ASL script, LiveSplit re-downloads all the files every time, so it would re-download the settings file as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would modify this file to change the settings, yes. It doesn't have any effect on the settings stored in any split files, if that's a concern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so you'd activate the autosplitter, which downloads the settings file. Then you'd modify the settings file to change the settings. But when you re-open LiveSplit, it would re-download the settings file and overwrite your changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm not understanding what you're getting at here. This file is not to be modified by users, just like the ASL file is not to be modified by users.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay, I misunderstood what the purpose of the settings file is, then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep exactly, it just holds the definitions for the settings rather than any information about what settings the user currently has. That's handled by livesplit and the settings window as normal.

Could I get a merge on this?

@just-ero just-ero merged commit 0d8d1fd into LiveSplit:master Dec 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants