-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pogo3D autosplitter with settings for full game #1612
Conversation
@@ -610,6 +610,7 @@ | |||
</Games> | |||
<URLs> | |||
<URL>https://raw.githubusercontent.com/mitchell-merry/autosplitters/main/Pogo3D/pogo3d.asl</URL> | |||
<URL>https://raw.githubusercontent.com/mitchell-merry/autosplitters/main/Pogo3D/Pogo3D.Settings.xml</URL> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this re-download the file every time you open LiveSplit, and overwrite the existing settings? Why not use LiveSplit's built in auto splitter settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a file that is loaded to provide the built-in auto splitter settings. For such a tiny amount of settings though, I hardly see the reason in offloading them to some other file. I created that feature for asl-help for auto splitters that have hundreds of settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have to modify this file later to change the settings? For an ASL script, LiveSplit re-downloads all the files every time, so it would re-download the settings file as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would modify this file to change the settings, yes. It doesn't have any effect on the settings stored in any split files, if that's a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so you'd activate the autosplitter, which downloads the settings file. Then you'd modify the settings file to change the settings. But when you re-open LiveSplit, it would re-download the settings file and overwrite your changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I'm not understanding what you're getting at here. This file is not to be modified by users, just like the ASL file is not to be modified by users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, I misunderstood what the purpose of the settings file is, then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep exactly, it just holds the definitions for the settings rather than any information about what settings the user currently has. That's handled by livesplit and the settings window as normal.
Could I get a merge on this?
If you are adding or modifying an Auto Splitter, please fill out this checklist: