Skip to content

Conversation

Jujstme
Copy link
Collaborator

@Jujstme Jujstme commented Sep 9, 2025

No description provided.

@AlexKnauth
Copy link
Collaborator

Something about how iter is used here feels off. As... for lack of a better word, a "static method"... used as Symbol::iter instead of the object.iter pattern used everywhere else in Rust.

@Jujstme
Copy link
Collaborator Author

Jujstme commented Sep 9, 2025

What about renaming it something like .read_from(process: &Process, module: impl Into<Address>)?

@AlexKnauth
Copy link
Collaborator

I think it was fine as it was with pe::symbols(process, module_address). Symbol::read_from(process, module_address) doesn't feel right for a function returning an iterator because there's no indication of plural or iteration.

@Jujstme Jujstme merged commit 9af21cd into LiveSplit:master Sep 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants