Fix game processes being in a zombie state when exiting #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the issue where the spawned game processes would never be removed from the system process list on Unix systems. The processes would stay in a zombie state because we weren't waiting for their exit as we should be doing under Unix systems.
The thread spawning code does not actually depend on the auto-splitting feature.
CryZe
requested changes
Aug 19, 2023
-Remove conditional use -Use of if let to remove the use of unwrap and make code cleaner
|
Should be better now, sorry about the little mess ups! |
-Rename child to _child for non Unix systems -Run cargo fmt on the source code
CryZe
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the game processes going into a zombie state when they exit on Unix systems.
We weren't properly waiting for their exit so this goes and fixes that.
The thread spawning approach may not be the best, but it works for this and we can think of an other solution if needed at some point.