Update z-index to prevent chat from showing up over 'rules' dialog #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if u could point this change to master, we'll handle the rest of the branch bs |
FlaminSarge
force-pushed
the
rules-dialog-fix
branch
from
cc13b19 to
3bf21be
Compare
KentoNishi
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Unsure if this style override is even necessary anymore but the rules dialog uses z-index 3 so this will paper over the issue for now, and I don't believe it reintroduces #134/etc.
Tested with Hyperchat enabled and disabled, handles both cases for the linked issue.
Alternatives:
Overriding the rules dialog's z-index to be 101 or something instead of doing this just seems like it will create a cascading set of overrides for stock YT chat behavior, which doesn't seem like the play.