Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/top bar bindings #1071

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Fix/top bar bindings #1071

merged 5 commits into from
Oct 25, 2023

Conversation

linusha
Copy link
Contributor

@linusha linusha commented Oct 20, 2023

No description provided.

@linusha linusha requested a review from merryman October 20, 2023 16:18
lively.ide/studio/top-bar-buttons.cp.js Outdated Show resolved Hide resolved
lively.ide/studio/top-bar-buttons.cp.js Outdated Show resolved Hide resolved
lively.ide/studio/top-bar.cp.js Outdated Show resolved Hide resolved
@linusha linusha force-pushed the fix/top-bar-bindings branch from b3eef76 to 18458f5 Compare October 24, 2023 16:15
@linusha linusha requested a review from merryman October 24, 2023 16:19
@linusha linusha force-pushed the fix/top-bar-bindings branch from 18458f5 to c99b5c4 Compare October 24, 2023 16:51
@merryman
Copy link
Member

I observed there was an issue with the changes we included in #1063, which made the custom positioning of the top bar menus ineffective. If you approve the changes, we can merge this in @linusha.

@linusha linusha force-pushed the fix/top-bar-bindings branch from 73eedf5 to e8287fa Compare October 25, 2023 11:15
@linusha linusha enabled auto-merge (rebase) October 25, 2023 11:16
@linusha linusha merged commit 9db68d0 into main Oct 25, 2023
6 checks passed
@linusha linusha deleted the fix/top-bar-bindings branch October 25, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants