Fix/overriding split inline policies #1497
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partitioned breakpoints also have breakpoints, but it does not really make sense to display the breakpoint control for them.
Partitioned policies are synthesized, and any override by definition, will revoke the splitting. Therefore it does not make sense to extend the existing master via `applyConfiguration()`
merryman
added
the
⏱️ postponed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a semantic problem with style policies, where overriding inline policies that are varied by different master dispatches will no longer be varied due to the way overridden properties are processed internally.
In effect this will cause previously dynamic inline policies to be strangely "stuck".
However there are also severe performance problems with the current implementation of style policies.
I am considering combining this fix into a future branch that also resolves performance issues.