Feature/source maps #1684
Open
Feature/source maps #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously would return the wrong expression for export {} statements that were directly adjacent to another object expression.
Merge the var and ref replacement and the import export traversal into single passes.
The key is here to make the node functions parametrized, so that depending on the underlying AST system different nodes can be created by the same transform.
Since babel.js has a bunch of circular imports it has weird importing specific code that checks if modules have been already initialized. We introduce a method called bulletProofNamespace() which helps us to adjust these error checking codes such that they work in split bundles.
Previously some weirdly formatted es modules from esm servers would not be categorized correctly.
Issue that happens if a local variable in a module has the same name as its exported alias, which the transformed code previously would cause to be overridden. This only works with the babel transform for now.
This was referenced Dec 10, 2024
merryman
force-pushed
the
feature/source-maps
branch
from
7046828 to
ddbf045
Compare
This is nessecary due to the chai upgrade.
Was needed due to to the changes in the class transform that preserves the class name as a binding during class initialization.
The transpiler initialization needed to be adjusted.
Due to upgrding chai, the comparison function that compares structs did not work any more since it started to compare prototypes as well. Wrapping the compared objects in JSON.parse/stringify seems to solve the issue.
merryman
force-pushed
the
feature/source-maps
branch
6 times, most recently
from
93a1698 to
d7b03ab
Compare
merryman
force-pushed
the
feature/source-maps
branch
from
2558a81 to
c80c9cc
Compare
merryman
force-pushed
the
feature/source-maps
branch
from
c95f679 to
5fb01b8
Compare
merryman
force-pushed
the
feature/source-maps
branch
from
5fb01b8 to
aa2a6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still fixing some performance issues.