Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/source maps #1684

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Feature/source maps #1684

wants to merge 63 commits into from

Conversation

merryman
Copy link
Member

Still fixing some performance issues.

@merryman merryman force-pushed the feature/source-maps branch from 7046828 to ddbf045 Compare December 10, 2024 15:37
@merryman merryman mentioned this pull request Dec 11, 2024
@merryman merryman force-pushed the feature/source-maps branch 8 times, most recently from 2558a81 to c80c9cc Compare December 16, 2024 20:42
@merryman merryman marked this pull request as ready for review December 16, 2024 21:12
@merryman merryman requested a review from linusha December 16, 2024 21:12
@merryman merryman force-pushed the feature/source-maps branch 3 times, most recently from aa2a6b1 to 7f2cfdd Compare December 19, 2024 17:30
Was previously not implemented at all for some reason?
Due to the upgrade in chai, we no longer have the chai subset convenience methods
This is nessecary due to the chai upgrade.
Was needed due to to the changes in the class transform that preserves the class name as a binding during class initialization.
The transpiler initialization needed to be adjusted.
Due to upgrding chai, the comparison function that compares structs did not work any more since it started to compare prototypes as well. Wrapping the compared objects in JSON.parse/stringify seems to solve the issue.
@merryman merryman force-pushed the feature/source-maps branch from 7f2cfdd to e10a6b1 Compare December 20, 2024 16:32
@merryman merryman force-pushed the feature/source-maps branch from e10a6b1 to d8ffcfc Compare December 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant