initial support for Deno #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiviaMedeiros
force-pushed
the
deno-initial-support
branch
from
a91acbc to
4e3e098
Compare
LiviaMedeiros
force-pushed
the
deno-initial-support
branch
from
5c7894d to
9eb977c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #2
fs.writeFile(_, body, _)Worked around by passing non-range requests as
-range. The implementation is sane enough, and there is no need to return206forPOSTorPUTmethods as a part of public API.fd.write(chunk, { length, position }The signature is ugly and it will probably require fixing for cases where
byteLength !== lengthbut it's better than it was.filehandle[Symbol.asyncDispose]Used
filehandle.close().