-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new API to modify display devices for Windows #2582
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2582 +/- ##
=========================================
- Coverage 8.96% 8.33% -0.64%
=========================================
Files 94 112 +18
Lines 17392 19105 +1713
Branches 8270 9209 +939
=========================================
+ Hits 1560 1592 +32
- Misses 12963 14481 +1518
- Partials 2869 3032 +163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Due to recent changes to the docs, all the doc changes to |
32e5255
to
b81c566
Compare
Very little note while I was going through my comments.. But HDR control may require a "extra" mode to plug into nvapi (which somehow I just noticed you already pulled in as a dependency?) for games that do their magic through it. |
For now this PR will focus on interacting with Windows API only and enabling "global" HDR setting only. |
I can't wait for this PR to get merged, I can't stress how amazing this is, thank you! If I were to take this, build it, install, would everything work as expected aside from a bug here or there? Assuming this would be the case but just want to verify since I'm not involved in this project. |
I play almost every day with this dev on Windows 11 and I have no problems. You can download it with your eyes closed |
@bradleycundari as moi952 just mentioned, you can download Github artifacts. However, they are needlessly hidden for someone without some previous knowledge: |
Yes, that was already being (very very confusedly) requested here. |
Please don't hijack this PR for off-topic discussions. |
This is a continuation of the #2032 PR after a rebase fiasco...
Description
New changes allow for Sunshine to control display devices on Windows, such as:
It also moves away from the
\\.\DISPLAY1
-like configurable output names to proper that are pretty persistent (IDs changed a little after I reinstalled my GPU drivers, after DDU).The applied changes are saved additionally saved to a file in case the PC dies or something so that Sunshine can undo the changes once it is started again.
Screenshot
Example of the new options exposed to the user:
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.
Known issues (all resolved)
IDD HDR driver displays high-contrast colors when the display is activated and was inactive before. Seems to be a driver issue, since it does not happen with HDR dongle. A workaround would be to reset all the HDR states to off and then on again, but I don't think we should implement this workaround for this.Sound fails to reset back to whatever was used before after the stream ends if a new display (without the same sink) was the only active display.