fix(packaging/windows): add Sunshine directories to system PATH

[ReenigneArcher]

Description

This PR was inspired after too many users have tried running sunshine --<command> from the wrong working directory.

The option via CPACK is too complex (see explanation below).

CPACK method

See https://cmake.org/cmake/help/latest/cpack_gen/nsis.html#variable:CPACK_NSIS_MODIFY_PATH

As far as I can tell there is no way to set the default options.

TODO:

• This doesn't currently work since we don't use a bin dir. https://gitlab.kitware.com/cmake/cmake/-/issues/15635

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.61%. Comparing base (7c8113d) to head (39019f0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3727   +/-   ##
=======================================
  Coverage   11.61%   11.61%           
=======================================
  Files          92       92           
  Lines       17337    17337           
  Branches     8100     8100           
=======================================
  Hits         2013     2013           
  Misses      12833    12833           
  Partials     2491     2491           

Flag	Coverage Δ
Linux	11.28% <ø> (ø)
Windows	13.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ReenigneArcher]

@cgutman My initial idea for this was to use the CPACK option to set the path, but ran into a bunch of issues with it.

1. It doesn't work unless ./bin exists
2. Moved the exe and tools to the bin directory, but then Sunshine had some issues.
3. Sunshine couldn't find the config directory. I was able to fix this.
4. Sunshine couldn't find assets directory (I think... unknown as Sunshine crashed and nothing useful in logs)... this would be far more complex to fix.
5. Setting the PATH worked sometimes, and other times it didn't work and required a re-install.
6. Cannot set default option to set the PATH or not.
7. The option to add desktop icon is not customizable and didn't ever work.

So, I started thinking it would be easier to just have an install/uninstall script. Any thoughts/opinions/questions on this approach.

These are mine:

1. Should we prompt to set the PATH or not? My thought is no prompt and just set it all the time.
2. Should tool binaries be moved so that they are also on the PATH? edit: added tools directory as well

Pull Request Overview

This PR addresses an issue with users running the program from the wrong working directory by updating the packaging instructions.

• Removed outdated uninstallation instructions from the documentation.
• Focused on clarifying the setup steps post-installation.

Files not reviewed (2)

• cmake/packaging/windows.cmake: Language not supported
• src_assets/windows/misc/path/update-path.bat: Language not supported

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud