Cancel cowswap orders #196
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
ac9dece
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e35e0dfb.llamaswap.pages.dev |
| Branch Preview URL: | https://cow-cancel.llamaswap.pages.dev |
| @@ -776,8 +788,6 @@ export function AggregatorContainer({ tokenList, sandwichList }) { | |||
| .wait?.() | |||
| ?.then((final) => { | |||
| if (final.status === 1) { | |||
| forceRefreshTokenBalance(); | |||
There was a problem hiding this comment.
need to refresh after swap, so we get cowswap order from db
| () => getSwapsHistory({ userId, chain, tokensUrlMap, tokensSymbolsMap }), | ||
| { | ||
| enabled: !!userId && !!chain && isOpen, |
There was a problem hiding this comment.
to fetch this on every cowswap order, so we can show loader near to history btn
| ?.map((swap) => { | ||
| const rawQuote = swap?.route?.price?.rawQuote; | ||
| if (swap.aggregator === 'CowSwap') { | ||
| const cowOrder = cowData?.data?.find((order) => order?.ethflowData?.userValidTo === rawQuote?.quote?.validTo); |
There was a problem hiding this comment.
why match using validTo? if there are 2 orders that expire at the same time wont this cause the matching to be incorrect?
There was a problem hiding this comment.
tried to find another way, but this will work since issa timestamp and 2 orders couldnt be placed at the same time
There was a problem hiding this comment.
looks good, but i think users wont be able to find that they have to go to order history in order to cancel the order
instead it would be better to change the post-tx dialog so that if its an order against cowswap we display a message explaining to the user that:
- if its an eth order it may take up to 30 minutes to execute and the eth is sitting in a contract, it didnt disappear. They can get the ETH back immediately by cancelling the order
- for other types of others they can cancel it by going to the history tab
the differentiation between eth orders and other orders should be automatic btw, so we only display the message that the user needs
No description provided.