Applies lint

LloydBlv · Feb 23, 2024 · c50f185 · c50f185
1 parent 7c883c9
commit c50f185
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 # 📸 FlickrSearch
 [![Android CI](https://github.com/LloydBlv/FlickrSearch/actions/workflows/android.yml/badge.svg)](https://github.com/LloydBlv/FlickrSearch/actions/workflows/android.yml)
 
-This is a sample app using Flickr API and Jetpack components (LiveData, ViewModel, ...). 
+This is a sample app using Flickr API and Jetpack components (LiveData, ViewModel, ...).
 
 The purpose of this app is to try new Android technologies and learn how it works and how it can be used in an app.
 

diff --git a/app/src/main/res/layout/item_search_result_layout.xml b/app/src/main/res/layout/item_search_result_layout.xml
@@ -20,6 +20,7 @@
             android:layout_height="96dp"
             app:imageUrl="@{photo.url}"
             android:scaleType="centerCrop"
+            android:contentDescription="@string/search_result_image"
             tools:srcCompat="@tools:sample/avatars" />
 
         <TextView

diff --git a/app/src/main/res/values-night/themes.xml b/app/src/main/res/values-night/themes.xml
@@ -10,7 +10,7 @@
         <item name="colorSecondaryVariant">@color/teal_200</item>
         <item name="colorOnSecondary">@color/black</item>
         <!-- Status bar color. -->
-        <item name="android:statusBarColor" tools:targetApi="l">?attr/colorPrimaryVariant</item>
+        <item name="android:statusBarColor">?attr/colorPrimaryVariant</item>
         <!-- Customize your theme here. -->
     </style>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -4,4 +4,5 @@
     <string name="press_on_search_button">Press on search button in the toolbar above to start searching</string>
     <string name="something_went_wrong">Something went wrong :(</string>
     <string name="search_has_no_result">Your search did not have any result :(</string>
+    <string name="search_result_image">search result image</string>
 </resources>
diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml
@@ -10,7 +10,7 @@
         <item name="colorSecondaryVariant">@color/teal_700</item>
         <item name="colorOnSecondary">@color/black</item>
         <!-- Status bar color. -->
-        <item name="android:statusBarColor" tools:targetApi="l">?attr/colorPrimaryVariant</item>
+        <item name="android:statusBarColor">?attr/colorPrimaryVariant</item>
         <!-- Customize your theme here. -->
     </style>
 </resources>
diff --git a/data/src/main/java/ir/zinutech/android/flickrsearch/data/features/search/SearchModule.kt b/data/src/main/java/ir/zinutech/android/flickrsearch/data/features/search/SearchModule.kt
@@ -27,7 +27,6 @@ abstract class SearchModule {
     abstract fun providePhotoUrlMapper(photoUrlMapper: FlickrPhotoUrlMapper): Mapper<FlickrPhotoDto, PhotoUrl>
 
     companion object {
-        @JvmStatic
         @Provides
         @Singleton
         fun provideSearchApi(retrofit: Retrofit): SearchApi {

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -1,6 +1,6 @@
 [versions]
 accompanist = "0.35.0-alpha"
-agp = "8.4.0-alpha10"
+agp = "8.4.0-alpha11"
 androidTools = "31.2.2"
 androidDesugarJdkLibs = "2.0.4"
 androidx-activity = "1.9.0-alpha03"