Control Center: Add missing Options, and Fix some #1347
Conversation
- Added new options for AccessibilityShortcuts, Battery (enum mode), Hearing, KeyboardBrightness, MusicRecognition, and updated UserSwitcher. - Updated existing options (Display, FocusModes, NowPlaying, ScreenMirroring, Sound) to use enum types with refined mapping values.
|
I just have doubt about the options that change their type, I know there are ways, but here I'm not sure how to add a warning or heads up, to indicate the allowed values had changed |
Iamanaws
force-pushed
the
controlcenter
branch
from
9ed9dd6 to
bf0b436
Compare
Iamanaws
force-pushed
the
controlcenter
branch
from
bf0b436 to
2362651
Compare
There was a problem hiding this comment.
A few comments on the options ;)
For the type change, we could have backward compatibility with warning by adding true & false in the mkXXXXApply mapping functions like:
mkEnumApply {
always = 21,
hide = 42,
true = lib.warn ''something something use "always" now'' 21,
false = lib.warn ''something something use `"hide"` now'' 42,
}|
|
||
| Show a Focus control in menu bar. Default is null. |
There was a problem hiding this comment.
(for all options)
I think we should keep the Show a Focus control in menu bar line in the description (or something similar), just having the path to the option in settings doesn't give much information..
It's still not very informative though since it's not clear what a 'focus control' is, but it's better than nothing 🤔
| 18 = Show in Menu Bar | ||
| 24 = Don't Show in Menu Bar |
There was a problem hiding this comment.
| 18 = Show in Menu Bar | |
| 24 = Don't Show in Menu Bar | |
| true = Show in Menu Bar (18) | |
| false = Don't Show in Menu Bar (24) |
Although, for a simple bool I'm not sure it's very useful to describe the option like this 👀 The description is enough for me.
| Show a battery energy mode. Default is null. | ||
|
|
||
| false - "When Active" | ||
| true - "Always" |
There was a problem hiding this comment.
Maybe don't use a boolean for this? an enum whenActive / always would be clearer.
OR rename the option like ...AlwaysShowBatteryEnergyMode so the boolean makes sense 🤔
| 18 = Show in Menu Bar | ||
| 24 = Don't Show in Menu Bar |
There was a problem hiding this comment.
| 18 = Show in Menu Bar | |
| 24 = Don't Show in Menu Bar | |
| true = Show in Menu Bar | |
| false = Don't Show in Menu Bar |
Or remove this section of the description?
| 18 = Show in Menu Bar | ||
| 24 = Don't Show in Menu Bar |
There was a problem hiding this comment.
| 18 = Show in Menu Bar | |
| 24 = Don't Show in Menu Bar | |
| true = Show in Menu Bar (18) | |
| false = Don't Show in Menu Bar (24) |
| false - "Don't Show in Menu Bar" | ||
| true - "Show in Menu Bar" |
There was a problem hiding this comment.
| false - "Don't Show in Menu Bar" | |
| true - "Show in Menu Bar" | |
| false - Don't Show in Menu Bar | |
| true - Show in Menu Bar |
No description provided.