syntax/nix: autogenerate namespaced builtins from nix __dump-language
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszlig
approved these changes
Feb 20, 2024
Ma27
force-pushed
the
builtins-generated
branch
from
e635a40
to
c059ff4
Compare
aszlig
reviewed
Feb 21, 2024
We had quite a bunch of changes in the past that added builtins to get them highlighted properly[1]. Nowadays it's possible to get this from Nix itself by running `nix __dump-language`. This was done on a recent Nix and includes all experimental features by default[2] which seems fine to me since this is not an LSP, but only an approximation. This patch adds a few new builtins, e.g. `break` and `flakeRefToString` and a script to regenerate the list. This doesn't include non-scoped builtins (e.g. `map`, `baseNameOf` etc.), but those are added far less frequent, so this seems OK to me. Also, there are a few hidden builtins, most notably `unsafe*` and `scopedImport`. I think this was done on purpose by upstream and I'm wondering if we should adhere to that approach. If we still want to keep those, I think we should add those to a custom highlighting group that's maintained manually. Co-authored-by: aszlig <[email protected]> [1] LnL7#44, LnL7#42, LnL7#36, LnL7#32, 711aaf7 [2] https://github.com/NixOS/nix/blob/2.20.1/src/nix/main.cc#L372
Ma27
force-pushed
the
builtins-generated
branch
from
c059ff4
to
1762e2b
Compare
LnL7
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had quite a bunch of changes in the past that added builtins to get them highlighted properly[1].
Nowadays it's possible to get this from Nix itself by running
nix __dump-language. This was done on a recent Nix and includes all experimental features by default[2] which seems fine to me since this is not an LSP, but only an approximation.This patch adds a few new builtins, e.g.
breakandflakeRefToStringand a script to regenerate the list.This doesn't include non-scoped builtins (e.g.
map,baseNameOfetc.), but those are added far less frequent, so this seems OK to me.Also, there are a few hidden builtins, most notably
unsafe*andscopedImport. I think this was done on purpose by upstream and I'm wondering if we should adhere to that approach. If we still want to keep those, I think we should add those to a custom highlighting group that's maintained manually.[1] #44, #42, #36, #32, 711aaf7
[2] https://github.com/NixOS/nix/blob/2.20.1/src/nix/main.cc#L372
cc @LnL7 @aszlig for opinions