Remove isomorphic-fetch due to vulnerabilities #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjimenezda
commented
Jan 29, 2025
| @@ -25,7 +25,7 @@ | |||
| "dependencies": { | |||
| "babel-runtime": "^6.20.0", | |||
| "glob": "^7.1.1", | |||
| "isomorphic-fetch": "^2.1.1", | |||
| "node-fetch": "^2.7.0", | |||
There was a problem hiding this comment.
The v3 version requires ESM, but this one should be fine security-wise.
rjimenezda
commented
Jan 29, 2025
Comment on lines
+4
to
+10
| if (!global.fetch) { | ||
| global.fetch = module.exports; | ||
| global.Response = nodeFetch.Response; | ||
| global.Headers = nodeFetch.Headers; | ||
| global.Request = nodeFetch.Request; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is just what isomorphic-fetch does on commonjs. Perhaps it could be hidden somehow, it feels kind of nasty out here.
Alternatively, the fetch implementation could be injected from outside, but it was overall a bigger change code and architecture-wise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We're in the process of removing a bunch of dependabot vulnerabilities in our project because of an upcoming audit, and have encountered that the latest version of logrocket-cli depends on isomorphic-fetch, which depends on a vulnerable version of node-fetch.
This PR drops isomorphic fetch in favour of using node-fetch directly. Node-fetch v1 is still in the lockfile, due to mock-fetch, but it's a devDependency, so it would not affect LogRocket's clients.
I'll leave some comments in the PR itself