Fix regression from v0.1: don't discard unsuccessful HTTP status codes

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "byhttp"
-version = "0.2.0"
+version = "0.2.1"
 authors = ["Lohikar <[email protected]>"]
 edition = "2018"
 publish = false

README.md

@@ -54,7 +54,6 @@ This is returned if the input to the function was invalid, or if ByHTTP failed t
 
 - `1` - Too few arguments passed to function.
 - `2` - Too many arguments passed to function.
-- `100` - Unknown HTTP error.
 - `101` - Connection timed out or failed to connect.
 - `102` - Too many redirects.
 - `200` - Error decoding or encoding JSON.

src/errors.rs

@@ -26,7 +26,6 @@ impl ByError {
 			Self::TooManyArgs => 2,
 			Self::Ureq(ureq::Error::Transport(t)) if t.kind() == ureq::ErrorKind::Io => 101,	// timeout
 			Self::Ureq(ureq::Error::Transport(t)) if t.kind() == ureq::ErrorKind::TooManyRedirects => 102,
-			Self::Ureq(ureq::Error::Status(..)) => 100,
 			Self::Ureq(..) => 99,
 			Self::Json { .. } => 200,
 			Self::BodyTooLarge => 201,

src/lib.rs

@@ -96,7 +96,12 @@ fn send_post_internal(args: Vec<Cow<'_, str>>) -> Result<(String, u16), ByError>
 		_ => unreachable!()
 	}
 
-	let response = req.send_string(&body)?;
+	// Match v0.1 behavior: don't discard unsuccessful HTTP error codes.
+	let response = match req.send_string(&body) {
+		Ok(val) => val,
+		Err(ureq::Error::Status(_code, resp)) => resp,
+		Err(e) => return Err(e.into())
+	};
 	let status = response.status();
 	let body = response.into_string().map_err(|_| ByError::BodyTooLarge)?;
 
@@ -123,7 +128,12 @@ fn send_get_internal(args: Vec<Cow<'_, str>>) -> Result<(String, u16), ByError>
 		_ => unreachable!(),
 	}
 
-	let response = req.call()?;
+	// Match v0.1 behavior: don't discard unsuccessful HTTP error codes.
+	let response = match req.call() {
+		Ok(val) => val,
+		Err(ureq::Error::Status(_code, resp)) => resp,
+		Err(e) => return Err(e.into())
+	};
 	let status = response.status();
 	let body = response.into_string().map_err(|_| ByError::BodyTooLarge)?;