-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl albums #263
feat: impl albums #263
Conversation
/// Shorthand for `Client::send_album`. | ||
pub async fn respond_album( | ||
&self, | ||
medias: Vec<InputMedia>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had in mind a slice of InputMedia
. But perhaps using a Vec
is okay, as it means we can take ownership and reduce clones. Not sure what's best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Vec
is the best option right now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely convinced. But we can definitely merge it like this for the time being and see how it feels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Isn't |
Yes, but this was deliberate, because not all messages are valid for album media. I think a new type is justified, because albums require media to be set, while What I did consider however, was using |
InputMedia
struct.send_album
,reply_album
andrespond_album
methods.