Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
Chat::name
,Chat::User::first_name
, andChat::Group::title
have sentinel values, occasionally returning empty strings, which is a bad code practice. The docs also don't mention all the cases when the strings are going to be empty.Telegram doesn't include all sender information because it assumes you already have it.
Originally posted by @Lonami in #212 (comment)
This creates confusion, leading to faulty code, as in #274 for example. Using
Option
will make it so users can't accidentally forget to check if the returned string is empty.