Migrating to futures::Stream for all iter_* method
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
took the data out of photo_size_data in `DownloadStream` instead of streaming return size_hint when available from DialogStream updated doctests updated DEPS.md
added MessageStream and GlobalSearchStream
|
Closing since all commits are now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I plan to rewrite all
iter_*methods to usefutures::Streaminstead of manual iterator implementation.Using
futures::Streamcould give us some very good advantages, for example there are tons of useful traits infuturesthat we can then use with ourStream's and its also overall a more standard way then what we are doing right now.Todo:
iter_download=>stream_downloaditer_dialogs=>stream_dialogsiter_participants=>stream_participantsiter_profile_photos=>stream_profile_photositer_messages=>stream_messagessearch_messages=>search_messagessearch_all_messages=>search_all_messagesQuestions:
stream_*? or is there better namesfuturescrate?pin_mutmacro everywhere doesn't seems like a good idea, what else should we do? should we implement custom future for lower level types?