Fix and add tests

Looky1173 · Aug 24, 2022 · 3881de1 · 3881de1
1 parent 3b74e2b
commit 3881de1
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 5 deletions.
diff --git a/src/core/__tests__/hash.test.js b/src/core/__tests__/hash.test.js
@@ -40,7 +40,7 @@ describe('hash', () => {
         const res = hash('compiled', 'target');
 
         expect(toHash).toBeCalledWith('compiled');
-        expect(update).toBeCalledWith('parse()', 'target', undefined);
+        expect(update).toBeCalledWith('parse()', 'target', undefined, null);
         expect(astish).toBeCalledWith('compiled');
         expect(parse).toBeCalledWith('astish()', '.toHash()');
 
@@ -53,7 +53,7 @@ describe('hash', () => {
         expect(toHash).not.toBeCalled();
         expect(astish).not.toBeCalled();
         expect(parse).not.toBeCalled();
-        expect(update).toBeCalledWith('parse()', 'target', undefined);
+        expect(update).toBeCalledWith('parse()', 'target', undefined, null);
 
         expect(res).toEqual('toHash()');
     });
@@ -64,7 +64,18 @@ describe('hash', () => {
         expect(toHash).toBeCalledWith('global');
         expect(astish).not.toBeCalled();
         expect(parse).not.toBeCalled();
-        expect(update).toBeCalledWith('parse()', 'target', undefined);
+        expect(update).toBeCalledWith('parse()', 'target', undefined, null);
+
+        expect(res).toEqual('toHash()');
+    });
+
+    it('regression: global-style-replace', () => {
+        const res = hash('global', 'target', true);
+
+        expect(toHash).not.toBeCalled();
+        expect(astish).not.toBeCalled();
+        expect(parse).not.toBeCalled();
+        expect(update).toBeCalledWith('parse()', 'target', undefined, 'parse()');
 
         expect(res).toEqual('toHash()');
     });
@@ -75,7 +86,7 @@ describe('hash', () => {
         expect(toHash).toBeCalledWith('keyframes');
         expect(astish).not.toBeCalled();
         expect(parse).not.toBeCalled();
-        expect(update).toBeCalledWith('parse()', 'target', undefined);
+        expect(update).toBeCalledWith('parse()', 'target', undefined, null);
 
         expect(res).toEqual('toHash()');
     });
@@ -89,7 +100,7 @@ describe('hash', () => {
         expect(toHash).toBeCalledWith('baz1');
         expect(astish).not.toBeCalled();
         expect(parse).toBeCalledWith({ baz: 1 }, '.' + className);
-        expect(update).toBeCalledWith('parse()', 'target', undefined);
+        expect(update).toBeCalledWith('parse()', 'target', undefined, null);
 
         expect(res).toEqual(className);
     });

diff --git a/src/core/__tests__/update.test.js b/src/core/__tests__/update.test.js
@@ -48,4 +48,17 @@ describe('update', () => {
         update('start', getSheet(), true);
         expect(extractCss()).toEqual('startend');
     });
+
+    it('regression: global style replacement', () => {
+        const t = { data: 'html, body { background-color: white; }' };
+
+        update(
+            'html, body { background-color: black; }',
+            t,
+            undefined,
+            'html, body { background-color: white; }'
+        );
+
+        expect(t.data).toEqual('html, body { background-color: black; }');
+    });
 });