Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas #2650

Open
wants to merge 1 commit into
base: release_loopring_3.6.3
Choose a base branch
from
Open

Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas #2650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/hebao_v1/contracts/modules/ControllerImpl.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,6 @@ contract ControllerImpl is Claimable, Controller
require(walletFactory == address(0), "INITIALIZED_ALREADY");
require(_walletFactory != address(0), "ZERO_ADDRESS");
walletFactory = _walletFactory;
emit AddressChanged("WalletFactory", walletFactory);
emit AddressChanged("WalletFactory", _walletFactory);
}
}
2 changes: 1 addition & 1 deletion packages/hebao_v1/legacy/version1.0/contracts/ControllerImpl.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ contract ControllerImpl is Claimable, Controller
{
require(_collectTo != address(0), "ZERO_ADDRESS");
collectTo = _collectTo;
emit ValueChanged("CollectTo", collectTo);
emit ValueChanged("CollectTo", _collectTo);
}

function setPriceOracle(PriceOracle _priceOracle)
Expand Down
2 changes: 1 addition & 1 deletion packages/lrc_v2/contracts/LRCFoundationIceboxContract_v2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ contract NewLRCFoundationIceboxContract {
lrcUnlockPerMonth = lrcInitialBalance.div(24); // 24 month
startTime = _startTime;

emit Started(startTime);
emit Started(_startTime);
}

function withdraw() public onlyOwner {
Expand Down
2 changes: 1 addition & 1 deletion packages/lrc_v2/contracts/NewLRCFoundationIceboxContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ contract NewLRCFoundationIceboxContract is Claimable {
lrcUnlockPerMonth = lrcInitialBalance.div(24); // 24 month
startTime = _startTime;

emit Started(startTime);
emit Started(_startTime);
}

function withdraw() public onlyOwner {
Expand Down