Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): 🎸 adjust default dpr to 75% of the machine dpr if greater than 1 #332

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

theashraf
Copy link
Member

resolve #329

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 1ffa584

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@lottiefiles/dotlottie-web Minor
@lottiefiles/dotlottie-react Patch
@lottiefiles/dotlottie-solid Patch
@lottiefiles/dotlottie-svelte Patch
@lottiefiles/dotlottie-vue Patch
@lottiefiles/dotlottie-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theashraf theashraf changed the title feat(web): 🎸 adjust default dpr to 75% of the machine dpr if > 1 feat(web): 🎸 adjust default dpr to 75% of the machine dpr if greater than 1 Aug 21, 2024
@theashraf theashraf self-assigned this Aug 21, 2024
Copy link
Contributor

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 52.49% / 30% 494 / 941
🟢 Statements 51.14% / 30% 514 / 1005
🟢 Functions 54.36% / 30% 137 / 252
🟢 Branches 55.23% / 30% 306 / 554
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/web/src/constants.ts 100% 100% 100% 100%
packages/web/src/dotlottie.ts 71.98% 63.15% 69.76% 74.78% 131, 135-138, 163, 204-206, 208, 243, 247, 292, 315, 319, 400, 416, 420, 449, 464-465, 480, 502-505, 529, 539, 567, 567, 569-572, 576, 581-584, 591, 591, 593-596, 600, 600, 602-605, 668, 668, 670-673, 677, 711, 738, 742, 752, 762, 762, 764-770, 774, 784, 788, 790-792, 791, 794, 798, 800-802, 801, 804, 808-810, 812-814, 816-819, 823, 825, 829, 831, 835, 837, 841, 843, 847, 849, 853, 862, 864-870, 865-870, 867-870, 869, 872, 876, 876, 878, 880, 882-884, 882-883, 886, 890-916, 891, 893-895, 894, 897-899, 898, 901-903, 902, 905-907, 906, 909-911, 910, 913-915, 914, 931, 935-936, 938-941, 945, 949, 953
packages/web/src/utils.ts 100% 91.66% 100% 100%
packages/web/src/worker/dotlottie.ts 61.62% 57.89% 70.27% 67.35% 13, 231, 249, 310, 361, 368, 375, 375, 377-378, 382, 396, 396, 398-399, 403, 418, 418, 420-421, 425, 435, 442, 442, 444-445, 449, 449, 451, 453-454, 471, 478, 485, 485, 487-488, 492, 499, 499, 501-502, 518, 525, 535, 562, 586, 586, 588, 590, 592, 596, 596, 598, 600, 602, 606, 606, 608, 610, 612, 614, 618, 618, 620, 622, 626, 626, 628, 632, 632, 634, 638-640, 642-644, 646-649, 653, 655, 659, 661, 665, 667, 671, 673, 677, 679, 683, 687-713, 688, 690-692, 691, 694-696, 695, 698-700, 699, 702-704, 703, 706-708, 707, 710-712, 711
Generated in workflow #1249

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 41.87 KB (+0.71% 🔺) 838 ms (+0.71% 🔺) 45 ms (+37.67% 🔺) 882 ms
@lottiefiles/dotlottie-web WASM 386.62 KB (0%) 7.8 s (0%) 0 ms (+100% 🔺) 7.8 s
@lottiefiles/dotlottie-react 45.72 KB (+0.57% 🔺) 915 ms (+0.57% 🔺) 119 ms (+198.25% 🔺) 1.1 s
@lottiefiles/dotlottie-vue 48.93 KB (+0.46% 🔺) 979 ms (+0.46% 🔺) 311 ms (+500.42% 🔺) 1.3 s
@lottiefiles/dotlottie-wc 49.18 KB (+0.55% 🔺) 984 ms (+0.55% 🔺) 226 ms (+146.23% 🔺) 1.3 s
@lottiefiles/dotlottie-svelte 49.86 KB (+0.58% 🔺) 998 ms (+0.58% 🔺) 156 ms (+149.71% 🔺) 1.2 s
@lottiefiles/dotlottie-solid 48.81 KB (+0.71% 🔺) 977 ms (+0.71% 🔺) 99 ms (+76.28% 🔺) 1.1 s

Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@theashraf theashraf merged commit 03311db into main Aug 22, 2024
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf(web): set default DPR to 75% of machine's DPR
2 participants