-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Auto-Manifest plugin #260
Conversation
Auto-Manifest automatically generates AndroidManifest packageName based on Gradle module structure. Since Splitties has `modules` and `fun-packs` separated, it would put `modules` in the middle of the package. That's why the plugin is applied under `modules/build.gradle.kts`. This made me realize a small issue on the plugin and released a fix. Once change required in the code was that `views-dsl` used `views.dsl.core` as packageName and I had to change the imports. Since these imports are not exposed, I don't think it is a breaking change.
It is nice that we have some unnecessary code removal. 84 lines added (unfortunately because I needed to add |
Can you retarget to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
There's a few possible improvements. If you want and have the time, please address them. Otherwise, please tell me and I'll do that myself before merging, no problem.
fb93404
to
a256718
Compare
@tasomaniac I think you've seen that the latest build fails (here's the error in the Gradle scan: https://scans.gradle.com/s/vswhzdzwuz6wa/console-log?task=:modules:views-dsl:compileDebugKotlinAndroid) It looks like the manifest of the |
Hmmm, there are other modules where their manifest is present in the same place. There is nothing special about that module. I will check soon. |
Fixes #248
Auto-Manifest automatically generates AndroidManifest packageName based on Gradle module structure. Since Splitties has
modules
andfun-packs
separated, it would putmodules
in the middle of the package. That's why the plugin is applied undermodules/build.gradle.kts
. This made me realize a small issue on the plugin and released a fix.One change required in the code (Preview.kt and UiPreview.kt) was that
views-dsl
usedviews.dsl.core
as packageName and I had to change the imports. Since these imports are not exposed, I don't think it is a breaking change.