-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.3 update, fixed timestamps #24
Open
CusYaBasic
wants to merge
15
commits into
LouisRaverdy:Unreal-Engine-5.1
Choose a base branch
from
CusYaBasic:Unreal-Engine-5.3
base: Unreal-Engine-5.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
5.3 update, fixed timestamps #24
CusYaBasic
wants to merge
15
commits into
LouisRaverdy:Unreal-Engine-5.1
from
CusYaBasic:Unreal-Engine-5.3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CusYaBasic
commented
Dec 3, 2023
- 5.3 update
- Fixed timestamps, wrong type was used
- Added GetStartTimestamp function; this just turns 'FDataTime::UTCNow' into a int64 which now correctly works with the timestamp features.
* 5.3 update * Fixed timestamps, wrong type was used * Added GetStartTimestamp function; this just turns 'FDataTime::UTCNow' into a int64 which now correctly works with the timestamp features.
Setup for game instance
Updated read me and docs
format errors
final typo errors
more typos
updates in readme
update docs/readme
Added more info in README
Last update for README
Nadwey
added a commit
to Nadwey/DiscordRPC-linux
that referenced
this pull request
Dec 7, 2023
Nadwey
reviewed
Dec 10, 2023
@@ -94,6 +99,10 @@ class DISCORDRPC_API UDiscordRpc : public UObject { | |||
GENERATED_BODY() | |||
|
|||
public: | |||
|
|||
UFUNCTION(BlueprintPure) | |||
int64 GetStartTimeStamp() const {return FDateTime::Now().ToUnixTimestamp();} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't UtcNow()
instead of Now()
be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, this has been fixed in the most recent version in my repos
WolfTM
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.