This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Solaris Fixes #1
Open
HeinrichHartmann
wants to merge
4
commits into
LuaDist:master
Choose a base branch
from
HeinrichHartmann:solaris_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
158cce3
Upgrade to Version 1.0
HeinrichHartmann 6809a25
Allocate lightuserdata on the heap.
HeinrichHartmann 76f742a
Enforce usage of our compile() implementation by renaming it
HeinrichHartmann 316227e
Add checks for calloc's return code.
HeinrichHartmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
|
||
#include <limits.h> | ||
#include <string.h> | ||
#include <stdlib.h> | ||
|
||
|
||
#include "lua.h" | ||
|
@@ -146,7 +147,7 @@ static int removedyncap (lua_State *L, Capture *capture, | |
*/ | ||
const char *match (lua_State *L, const char *o, const char *s, const char *e, | ||
Instruction *op, Capture *capture, int ptop) { | ||
Stack stackbase[INITBACK]; | ||
Stack *stackbase = calloc(INITBACK, sizeof(Stack)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No sanity check present in case of failure. |
||
Stack *stacklimit = stackbase + INITBACK; | ||
Stack *stack = stackbase; /* point to first empty slot in stack */ | ||
int capsize = INITCAPSIZE; | ||
|
@@ -168,10 +169,12 @@ const char *match (lua_State *L, const char *o, const char *s, const char *e, | |
assert(stack == getstackbase(L, ptop) + 1); | ||
capture[captop].kind = Cclose; | ||
capture[captop].s = NULL; | ||
free(stackbase); | ||
return s; | ||
} | ||
case IGiveup: { | ||
assert(stack == getstackbase(L, ptop)); | ||
free(stackbase); | ||
return NULL; | ||
} | ||
case IRet: { | ||
|
@@ -345,7 +348,7 @@ const char *match (lua_State *L, const char *o, const char *s, const char *e, | |
p++; | ||
continue; | ||
} | ||
default: assert(0); return NULL; | ||
default: assert(0); free(stackbase); return NULL; | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sanity check in case of failure.