Skip to content

fix: don't return empty hover #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

fix: don't return empty hover #3232

merged 2 commits into from
Jul 18, 2025

Conversation

phanen
Copy link
Contributor

@phanen phanen commented Jul 17, 2025

Nvim show me an error(since: neovim/neovim#34789), when I hover an symbol
whose definition cannot be found by luals

**/neovim/runtime/lua/vim/lsp/util.lua:1685: 'width' key must be a
positive Integer

To reprodunce, hover on a with this file

---@type a

Haven't reproduced with other lsp but I think it's harmless to PR here.

@phanen phanen force-pushed the fix-empty-hover branch from 749da7a to 7ac2b91 Compare July 17, 2025 10:42
Nvim show me an error(since:
neovim/neovim#34789), when I hover an symbol
whose definition cannot be found by luals
```
**/neovim/runtime/lua/vim/lsp/util.lua:1685: 'width' key must be a
positive Integer
```

To reprodunce, hover on a with this file
```lua
---@type a
```

Haven't reproduced with other lsp but I think it's harmless to PR here.
@phanen phanen force-pushed the fix-empty-hover branch from 7ac2b91 to 3b55edc Compare July 17, 2025 10:54
@sumneko sumneko merged commit 7dd611a into LuaLS:master Jul 18, 2025
11 checks passed
@sumneko
Copy link
Collaborator

sumneko commented Jul 18, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants