Skip to content

fix: don't return empty hover #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* `CHG` Rename configuration option `Lua.diagnostics.disableScheme` to `Lua.diagnostics.validScheme` and improve its description. Now it enables diagnostics for Lua files that use the specified scheme.
* `FIX` adds the `|lambda|` operator to the `Lua.runtime.nonstandardSymbol` configuration template, which allows the use of that option. Previously, support for it existed in the parser, but we could not actually use the option because it is not recognised in the configuration.
* `FIX` Typed `@field` (eg `---@field [string] boolean`) should not override other defined field [#2171](https://github.com/LuaLS/lua-language-server/issues/2171), [#2711](https://github.com/LuaLS/lua-language-server/issues/2711)
* `FIX` don't return empty hover doc when luals failed to find definition

## 3.15.0
`2025-6-25`
Expand Down
6 changes: 5 additions & 1 deletion script/provider/provider.lua
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,13 @@ m.register 'textDocument/hover' {
if not hover or not source then
return nil
end
local value = tostring(hover)
if #value == 0 then
return nil
end
return {
contents = {
value = tostring(hover),
value = value,
kind = 'markdown',
},
range = converter.packRange(state, source.start, source.finish),
Expand Down
Loading