fix: sidebar move page test

LucasXu0 · Sep 22, 2024 · 043090a · 043090a
1 parent f0a494b
commit 043090a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/frontend/appflowy_flutter/integration_test/cloud/cloud_runner.dart b/frontend/appflowy_flutter/integration_test/cloud/cloud_runner.dart
@@ -8,6 +8,7 @@ import 'workspace/change_name_and_icon_test.dart'
     as change_workspace_name_and_icon_test;
 import 'workspace/collaborative_workspace_test.dart'
     as collaboration_workspace_test;
+import 'workspace/workspace_settings_test.dart' as workspace_settings_test;
 
 Future<void> main() async {
   preset_af_cloud_env_test.main();
@@ -18,6 +19,7 @@ Future<void> main() async {
   // workspace
   collaboration_workspace_test.main();
   change_workspace_name_and_icon_test.main();
+  workspace_settings_test.main();
 
   // document
   document_drag_block_test.main();

diff --git a/frontend/appflowy_flutter/integration_test/cloud/sidebar/sidebar_move_page_test.dart b/frontend/appflowy_flutter/integration_test/cloud/sidebar/sidebar_move_page_test.dart
@@ -62,12 +62,16 @@ void main() {
       );
 
       // expect to see two pages
+      // one is in the sidebar, the other is in the move to page list
       // 1. Getting started
       // 2. To-dos
-      final gettingStarted = find.text(Constants.gettingStartedPageName);
-      // one is in the sidebar, the other is in the move to page list
+      final gettingStarted = find.findTextInFlowyText(
+        Constants.gettingStartedPageName,
+      );
+      final toDos = find.findTextInFlowyText(Constants.toDosPageName);
+      await tester.pumpUntilFound(gettingStarted);
+      await tester.pumpUntilFound(toDos);
       expect(gettingStarted, findsNWidgets(2));
-      final toDos = find.text(Constants.toDosPageName);
       expect(toDos, findsNWidgets(2));
 
       // hover on the todos page, and will see a forbidden icon

diff --git a/...appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/move_to/move_page_menu.dart b/...appflowy_flutter/lib/workspace/presentation/home/menu/sidebar/move_to/move_page_menu.dart
@@ -127,9 +127,6 @@ class _MovePageMenuState extends State<MovePageMenu> {
               isHovered: isHoveredNotifier,
               isExpandedNotifier: isExpandedNotifier,
               shouldIgnoreView: (view) {
-                debugPrint(
-                  'view: ${view.id}, layout: ${view.layout}, sourceView: ${widget.sourceView.id}',
-                );
                 if (_shouldIgnoreView(view, widget.sourceView)) {
                   return IgnoreViewType.hide;
                 }

diff --git a/frontend/appflowy_flutter/pubspec.lock b/frontend/appflowy_flutter/pubspec.lock
@@ -1559,10 +1559,10 @@ packages:
     dependency: transitive
     description:
       name: platform
-      sha256: "12220bb4b65720483f8fa9450b4332347737cf8213dd2840d8b2c823e47243ec"
+      sha256: "9b71283fc13df574056616011fb138fd3b793ea47cc509c189a6c3fa5f8a1a65"
       url: "https://pub.dev"
     source: hosted
-    version: "3.1.4"
+    version: "3.1.5"
   plugin_platform_interface:
     dependency: "direct dev"
     description:
@@ -1989,10 +1989,10 @@ packages:
     dependency: transitive
     description:
       name: string_scanner
-      sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde"
+      sha256: "688af5ed3402a4bde5b3a6c15fd768dbf2621a614950b17f04626c431ab3c4c3"
       url: "https://pub.dev"
     source: hosted
-    version: "1.2.0"
+    version: "1.3.0"
   string_validator:
     dependency: "direct main"
     description:
@@ -2311,10 +2311,10 @@ packages:
     dependency: transitive
     description:
       name: vm_service
-      sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
+      sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d"
       url: "https://pub.dev"
     source: hosted
-    version: "14.2.1"
+    version: "14.2.5"
   watcher:
     dependency: transitive
     description: