-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config validation #34
Added config validation #34
Conversation
532517c
to
3d4aedd
Compare
Added an additional |
README.md
Outdated
## Syntax check | ||
To check if the config has a valid syntax, the following command can be used. | ||
|
||
`cargo run -- --dry-run` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I like the use of cargo run
over calling an installed command like crab-hole
here. The readme so far only suggests installing this program, not running it in its source folder. @LuckyTurtleDev what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. This should be changed.
Due to cargo
being the only command listed, I just went with it.
I think it might be good to add an Running crab-hole section, or something similar.
Should this call the installed command, likely crab-hole
, or just mention the additional flags?
I personally would prefer to use sub commands for https://docs.rs/clap/4.5.22/clap/_derive/_tutorial/chapter_2/index.html#subcommands Everything else looks fine 👍 |
This allows to verify the config, as well as block and allowlists, without starting the DNS server